fix: 동아리 모집 생성 API를 PUT으로 생성/수정 기능 통합 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
이 PR은 동아리 모집 공고 생성과 수정 기능을 하나의 PUT 엔드포인트로 통합합니다.
Changes:
POST /clubs/{clubId}/recruitments엔드포인트를 제거하고PUT /clubs/{clubId}/recruitments로 생성/수정 기능을 통합ClubRecruitmentCreateRequest와ClubRecruitmentUpdateRequestDTO를ClubRecruitmentUpsertRequest로 통합- 모집 공고 생성 권한을 회장 전용에서 회장+매니저로 확대 (수정 권한과 동일하게 변경)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ClubService.java | createRecruitment와 updateRecruitment 메서드를 upsertRecruitment 메서드로 통합하여 생성/수정 로직을 하나로 처리 |
| ClubRecruitmentUpsertRequest.java | 기존 ClubRecruitmentCreateRequest를 ClubRecruitmentUpsertRequest로 이름 변경 |
| ClubRecruitmentUpdateRequest.java | 중복된 DTO 파일 제거 |
| ClubController.java | createRecruitment와 updateRecruitment 메서드를 upsertRecruitment 메서드로 통합 |
| ClubApi.java | API 문서를 업데이트하여 upsert 기능을 정확하게 설명하고 관련 없는 에러 코드 제거 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
POST /clubs/{clubId}/recruitments엔드포인트를 제거했습니다.PUT /clubs/{clubId}/recruitments엔드포인트에생성기능도 추가했습니다.동아리 관리 권한은
임원진급 이상이면 모두 가능하도록 해야하므로, 추후에 작업할 예정입니다.💬 참고 사항
✅ Checklist (완료 조건)